Skip to content

Add yield expression test#49

Merged
phisiart merged 5 commits intogoogle:mainfrom
tihiera:add-yield-expression-test
Apr 7, 2026
Merged

Add yield expression test#49
phisiart merged 5 commits intogoogle:mainfrom
tihiera:add-yield-expression-test

Conversation

@tihiera
Copy link
Copy Markdown
Contributor

@tihiera tihiera commented Apr 6, 2026

Adds a conversion test for yield_expression, covering both yield and yield* (delegate). This construct was supported in the IR (JsirYieldExpressionOp) but had no conversion test.

Test files were generated using generate_tests.py. The test verifies:

  • JS source → AST parsing
  • AST → JSHIR lowering (including the delegate attribute)
  • Full roundtrip: source → AST → JSHIR → AST → source

@phisiart
Copy link
Copy Markdown
Collaborator

phisiart commented Apr 7, 2026

Thanks for the PR! This repo is automatically sync'ed from our internal codebase, so let me figure out a way to check in your PR without breaking the sync process (similar to #48).

@hossainjm
Copy link
Copy Markdown
Collaborator

Created internal cl/896092371 to match this PR. We will submit the PR.

@phisiart phisiart merged commit dbada3b into google:main Apr 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants